Optimize compilation with Ninja#31449
Merged
zhwesky2010 merged 6 commits intoPaddlePaddle:developfrom Mar 16, 2021
Merged
Conversation
|
Hi, It's a test PR, it will not trigger CI. If you want to trigger CI, please remove |
Avin0323
changed the title
zhwesky2010
reviewed
Mar 15, 2021
| -DCMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS} | ||
| -DCMAKE_CXX_FLAGS_RELEASE=${CMAKE_CXX_FLAGS_RELEASE} | ||
| -DCMAKE_CXX_FLAGS_DEBUG=${CMAKE_CXX_FLAGS_DEBUG} | ||
| -DCMAKE_C_FLAGS=$<FILTER:${CMAKE_C_FLAGS},EXCLUDE,/Zc:inline> |
Contributor
There was a problem hiding this comment.
这里为什么做特殊处理呢？warpctc和其他第三方有特殊地方吗
Contributor
Author
There was a problem hiding this comment.
warpctc会将CXX FLAGS用在编译CUDA上，这样会导致缺少部分device函数。
zhwesky2010
approved these changes
Mar 15, 2021
Contributor
zhwesky2010
left a comment
zhwesky2010
left a comment
There was a problem hiding this comment.
还有一些Ninja无法识别的warning，后面可以一起处理下
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Windows下，对比MSVC，使用Ninja构建缺少
/Zc:inline编译参数，手动添加。/Zc:inline：删除不用的函数符号。测试日志：https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/2508529/job/3505578